[fix](regression) Batch export_p0 generated VALUES inserts#65208
Merged
HappenLee merged 1 commit intoJul 5, 2026
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Reviewed PR #65208.
I found no blocking issues and no inline comments to submit.
Critical checkpoint conclusions:
- Goal and tests: the PR batches the generated
INSERT ... VALUESsetup rows in the three changed export_p0 suites while preserving the same row sets. Existing orderedqt_select_defaultchecks and OUTFILE comparisons still validate the exported results, and no.outupdate is needed because expected query output is unchanged. - Scope: the change is small and limited to regression-test setup code in
test_outfile_native.groovy,test_outfile.groovy, andtest_outfile_expr.groovy. - Concurrency/lifecycle/config/compatibility/persistence: no product runtime code, persisted format, FE/BE protocol, or configuration item is changed. The added batching executes sequentially in the same suite setup path.
- Parallel or related paths: checked the changed local/native export suites and analogous outfile test patterns; I did not find a distinct parallel-path issue introduced by this PR.
- Test results and style:
git diff --checkis clean for the base/head diff. I did not run the regression suite because this checkout lacksthirdparty/installed,thirdparty/installed/bin/protoc, and a Doris regression cluster. - Performance: replacing one large literal VALUES statement with 500-row batches addresses the stated Cloud P0 planning timeout risk without changing the tested output semantics.
Subagent conclusions:
optimizer-rewrite: no optimizer/rewrite correctness, semantic equivalence, or parallel join/aggregate issue found; final convergence returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no regression expected-output, session/config propagation, compatibility, or CI/style issue found; final convergence returnedNO_NEW_VALUABLE_FINDINGS.
User focus points: no additional user-provided review focus was present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related: DORIS-26804
Testing